Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed testing image from being used in non-test artifacts (fixes #170) #171

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

gramidt
Copy link
Member

@gramidt gramidt commented Jan 22, 2021

Signed-off-by: Granville Schmidt 1246157+gramidt@users.noreply.github.com

Resolves Issue: #170

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
@gramidt gramidt requested a review from jpkrohling as a code owner January 22, 2021 23:50
@gramidt
Copy link
Member Author

gramidt commented Jan 23, 2021

Looking into e2e failure now.

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Makefile Show resolved Hide resolved
@gramidt
Copy link
Member Author

gramidt commented Jan 23, 2021

The latest error from e2e:

 logger.go:42: 00:34:58 |  | Error from server: error when creating "./tests/_build/manifests/01-opentelemetry-operator.yaml": conversion webhook for cert-manager.io/v1alpha2, Kind=Issuer failed: Post "https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s": x509: certificate signed by unknown authority

@jpkrohling - I may be able to also look into this issue either tonight or tomorrow.

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
@gramidt
Copy link
Member Author

gramidt commented Jan 23, 2021

Appears the e2e certificate issue didn't appear after re-running the e2e tests. Maybe we should open an issue and look into it further...

@mergify mergify bot merged commit 2d4486e into open-telemetry:master Jan 25, 2021
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
…-telemetry#170) (open-telemetry#171)

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>

Resolves Issue: open-telemetry#170
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…-telemetry#170) (open-telemetry#171)

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>

Resolves Issue: open-telemetry#170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants